[Concurrency] Handle actor isolation for defers in closures #60688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theblixguy
force-pushed
the
defer-isolation-closures
branch
2 times, most recently
from
3ac0da6
to
5272509
Compare
theblixguy
force-pushed
the
defer-isolation-closures
branch
from
5272509
to
dd668d3
Compare
|
ping |
kavon
approved these changes
Aug 31, 2022
|
@swift-ci please smoke test and merge |
|
Hm seems CI is blocked on an unrelated lldb failure in |
|
@swift-ci please smoke test and merge |
|
When will this change be released? It appears that the previous error is still present in Xcode 14.2 (14C18). |
|
@clayellis The fix should be in 5.8 (Xcode 14.3 beta). It was only reverted from the 5.7 branch, not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #58921
Resolves #57673
deferbodies share actor isolation with its parent context, so tweakgetActorIsolationOfContextto handledefer(instead of doing it in a ad-hoc way). This method is called from a bunch of places so IMO it's better to handle it there. This also solves the bug where we were not handlingdeferin closures (but it worked fine in functions)(edit by @kavon): also resolves rdar://92408225