Delete _InternalSwiftSyntaxParser And Its Build Infrastructure #61898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the start of the removal of the C++ implementation of libSyntax in favor of the new Swift Parser and Swift Syntax libraries. Now that the Swift Parser has switched the SwiftSyntaxParser library over to being a thin wrapper around the Swift Parser, there is no longer any reason we need to retain any libSyntax infrastructure in the swift compiler. As a first step, delete the infrastructure that builds lib_InternalSwiftSyntaxParser and convert any scripts that mention it to instead mention the static mirror libraries. The --swiftsyntax build-script flag has been retained and will now just execute the SwiftSyntax and Swift Parser builds with the just-built tools.
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test Linux |
|
@swift-ci smoke test Linux |
1 similar comment
|
@swift-ci smoke test Linux |
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
|
apple/swift-integration-tests#103 @swift-ci test Linux |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the start of the removal of the C++ implementation of libSyntax in favor of the new Swift Parser and Swift Syntax libraries. Now that the swift-syntax project has switched the SwiftSyntaxParser library over to being a thin wrapper around the Swift Parser, there is no longer any reason we need to retain any libSyntax infrastructure in the swift compiler.
As a first step, delete the infrastructure that builds lib_InternalSwiftSyntaxParser and convert any scripts that mention it to instead mention the static mirror libraries. The --swiftsyntax build-script flag has been retained and will now just execute the SwiftSyntax and Swift Parser builds with the just-built tools.