Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdlib: install SwiftGlibc.h in static resources directory #62209

Conversation

mhjacobson
Copy link
Contributor

When SwiftGlibc.h was added in #32404, no cmake code was added to copy it to the static resources. Copy it along with glibc.modulemap, which references it.

When SwiftGlibc.h was added in swiftlang#32404, no cmake code was added to copy it to the
static resources.  Copy it along with glibc.modulemap, which references it.
Copy link
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks!

@egorzhdan
Copy link
Contributor

@swift-ci please smoke test

@egorzhdan
Copy link
Contributor

@swift-ci please smoke test macOS

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The re-ordering made the diff more difficult to read. It would be nice to split that out in the future.

@mhjacobson
Copy link
Contributor Author

Looks like tests passed. Could someone merge, please? Thanks!

@mhjacobson mhjacobson merged commit a90d24a into swiftlang:main Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants