Add an assertion that verifies the size of cached debug info types. #62499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-prantl
force-pushed
the
102367872
branch
from
1a01aac
to
722bd91
Compare
adrian-prantl
force-pushed
the
102367872
branch
from
722bd91
to
22f5ade
Compare
|
@swift-ci test |
adrian-prantl
force-pushed
the
102367872
branch
from
22f5ade
to
956f8ab
Compare
|
@swift-ci test |
|
@swift-ci test source compatibility |
adrian-prantl
force-pushed
the
102367872
branch
from
956f8ab
to
fef2ae3
Compare
|
@swift-ci test |
|
@swift-ci test source compatibility |
adrian-prantl
force-pushed
the
102367872
branch
from
fef2ae3
to
1136035
Compare
|
@swift-ci test |
adrian-prantl
force-pushed
the
102367872
branch
from
1136035
to
600fc62
Compare
|
@swift-ci test source compatibility |
|
@swift-ci test |
augusto2112
approved these changes
Dec 21, 2022
adrian-prantl
force-pushed
the
102367872
branch
from
600fc62
to
84f12fa
Compare
|
@swift-ci test |
|
@swift-ci test source compatibility |
|
Nice, the only failure is an unrelated linker crash. |
|
@swift-ci test and merge |
|
@swift-ci test |
|
@swift-ci test macos |
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test platform macOS |
|
@swift-ci test macOS |
1 similar comment
|
@swift-ci test macOS |
…ypeInfo. Previously type sizes would be inconsistently sourced from either the LLVM type or the FixedTypeInfo, depending on the call site. This was problematic because TypeInfo operates with a resolution of whole bytes, which means that types such as i1 would get a reported as having a size of 8. This patch now asserts that all occurrences of the same type have the same size as the first, cached occurence. To avoid triggering the cached type verification assertion, this patch avoids caching of storage-sized containers. It also removes the unique identifier from forward declarations, which could lead to type confusion during LTO. rdar://102367872
adrian-prantl
force-pushed
the
102367872
branch
from
84f12fa
to
0f4429b
Compare
|
@swift-ci test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DebugTypeInfo: Prefer the size of the Storage type derived from the TypeInfo.
Previously type sizes would be inconsistently sourced from either the LLVM type
or the FixedTypeInfo, depending on the call site. This was problematic because
TypeInfo operates with a resolution of whole bytes, which means that types such
as i1 would get a reported as having a size of 8. This patch now asserts that
all occurrences of the same type have the same size as the first, cached
occurence.
To avoid triggering the cached type verification assertion, this patch avoids
caching of storage-sized containers. It also removes the unique identifier from
forward declarations, which could lead to type confusion during LTO.
rdar://102367872