Don't build arm64e slice for back compatibility archives in Darwin #62815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please build toolchain |
Addresses rdar://102275287
edymtt
force-pushed
the
no-arm64e-in-compatibility-archives-for-darwin
branch
from
085dbba
to
87046d8
Compare
|
@swift-ci please test |
|
@swift-ci please build toolchain |
etcwilde
reviewed
Jan 3, 2023
| @@ -50,6 +50,19 @@ if(SWIFT_BUILD_STDLIB) | |||
| add_subdirectory(CompatibilityBytecodeLayouts) | |||
| endif() | |||
|
|
|||
| macro(dont_target_arm64e_for_products_configured_in_this_folder) | |||
There was a problem hiding this comment.
Not a huge fan of the macro. PARENT_SCOPE may be useful here. Alternatively, depending on how many Darwin SDKs we have, I'd prefer inlining the list remove item in the CMakeLists.txt file for each library. The Compatibility 50 and 51 libraries already have list(REMOVE_ITEM SWIFT_SDK_WATCHOS_ARCHITECTURES "arm64" "arm64e") in them. In the event that the list of SDKs changes, we already have to edit the library files anyway to fix the deployment target version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses rdar://102275287