[Diagnostics] Add a swift-syntax diagnostic style #63153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SwiftDiagnostics module within swift-syntax has a diagnostic pretty-printer that does a nice rendering of the source code with diagnostics placed inside gaps between the code lines. Introduce another `-diagnostic-style` argument, `swift-syntax`, to bridge from the pretty-printed C++ diagnostics over to the swift-syntax diagnostics engine.
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
Thanks to @flashspys for implementing the nice diagnostics formatter on the SwiftSyntax side. |
| @@ -32,7 +32,7 @@ class DiagnosticOptions { | |||
| VerifyAndApplyFixes | |||
| } VerifyMode = NoVerify; | |||
|
|
|||
| enum FormattingStyle { LLVM, Swift }; | |||
| enum FormattingStyle { LLVM, Swift, SwiftSyntax }; | |||
There was a problem hiding this comment.
Should we update Options.td to mention this new option?
Edit: Probably a bad idea if we want it to supersede the "swift" formatter eventually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SwiftDiagnostics module within swift-syntax has a diagnostic pretty-printer that does a nice rendering of the source code with diagnostics placed inside gaps between the code lines. Introduce another
-diagnostic-styleargument,swift-syntax, to bridge from the pretty-printed C++ diagnostics over to the swift-syntax diagnostics engine.The diagnostics emitted here are pretty nice, but can certainly be improved with some work on the swift-syntax formatter itself: