Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stdlib][string] Replace loop for cstring length calculation with call of intrinsic #63384

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[stdlib][string] Replace loop for cstring length calculation with call of intrinsic #63384

wants to merge 1 commit into from

Conversation

valeriyvan
Copy link
Contributor

No description provided.

@valeriyvan
Copy link
Contributor Author

ping

3 similar comments
@valeriyvan
Copy link
Contributor Author

ping

@valeriyvan
Copy link
Contributor Author

ping

@valeriyvan
Copy link
Contributor Author

ping

@AnthonyLatsis
Copy link
Collaborator

@milseman ping

1 similar comment
@valeriyvan
Copy link
Contributor Author

@milseman ping

milseman
milseman approved these changes Apr 23, 2023
View reviewed changes
Copy link
Contributor

@milseman milseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @lorentey any concerns?

lorentey
lorentey approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@lorentey lorentey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lorentey
Copy link
Member

lorentey commented May 1, 2023

@swift-ci test and merge

@valeriyvan
Copy link
Contributor Author

ping

@AnthonyLatsis
Copy link
Collaborator

@swift-ci please smoke test

@AnthonyLatsis
Copy link
Collaborator

@valeriyvan If the tests fail again, please inspect the logs for anything left to address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milseman milseman milseman approved these changes

@lorentey lorentey lorentey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@valeriyvan @AnthonyLatsis @lorentey @milseman