Warn on implicit raw pointer conversion to non-bitwise-copyable values #63825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci toolchain |
|
@swift-ci test source compatibility |
|
@swift-ci Please Build Toolchain macOS Platform |
atrick
force-pushed
the
diagnose-implicit-raw-bitwise
branch
from
d65a6a4
to
6cf0e2e
Compare
|
@swift-ci test |
|
@swift-ci Please Build Toolchain macOS Platform |
|
@swift-ci test source compatibility |
atrick
force-pushed
the
diagnose-implicit-raw-bitwise
branch
from
6cf0e2e
to
54f7aad
Compare
|
@swift-ci test |
atrick
force-pushed
the
diagnose-implicit-raw-bitwise
branch
from
54f7aad
to
9b30bff
Compare
|
@swift-ci smoke test |
atrick
force-pushed
the
diagnose-implicit-raw-bitwise
branch
from
9b30bff
to
1ecc3f8
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke test macOS platform |
|
@swift-ci build toolchain |
xedin
approved these changes
Feb 23, 2023
atrick
force-pushed
the
diagnose-implicit-raw-bitwise
branch
from
1ecc3f8
to
2c60527
Compare
|
@swift-ci test |
This is also needed in SIL diagnostics, not just Sema diagnostics, because implicit Array conversion generates special SIL patterns.
Fixes a usability problem with implicit inout conversion to raw pointers.
For example, supporting this conversion turns out to be bad:
void read_void(const void *input);
func foo(data: inout Data) {
read_void(&data)
}
People understandably expect Foundation.Data to have the same sort of
implicit conversion as Array. But it does something very wrong
instead.
We could have added an an attribute to Data and other copy-on-write
containers to selectively suppress implicit conversion. But there is
no good reason to allow implicit conversion from any non-trivial
type. It is extremely dangerous, and almost always accidental. Note
that this problem becomes worse now that the compiler views imported
`char *` arguments as raw pointers. For example:
void read_char(const char *input);
var object: AnyObject = ...
read_void(&object1)
This seems like a good time to correct this old Swift 3 behavior.
Plan: Add a warning now. Convert it to an error in Swift 6 language
mode based on feedback.
Fixes rdar://97963116 (It's really easy to accidentally corrupt a Data
object with the & operator)
atrick
force-pushed
the
diagnose-implicit-raw-bitwise
branch
from
2c60527
to
a354f26
Compare
|
@swift-ci test |
|
@swift-ci toolchain |
|
@swift-ci test source compatibility |
|
@swift-ci smoke test |
atrick
changed the title
atrick
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a usability problem with implicit inout conversion to raw pointers.