Fix some bugs with variadic tuple lowering and value-op outlining #64293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lot of the fixes here are adjustments to compensate in the fulfillment and metadata-path subsystems for the recent pack substitutions representation change. I think these adjustments really make the case for why the change was the right one to make: the code was clearly not considering the possibility of packs in these positions, and the need to handle packs makes everything work out much more cleanly. There's still some work that needs to happen around type packs; in particular, we're not caching them or fulfilling them as a whole, and we do have the setup to do that properly now.
|
@swift-ci Please test |
…type. Previously it was testing for opened existentials specifically. We should really teach outlining to handle local archetypes properly. We'd have to build a generic signature for the lowered type, and that probably means also adding requirements that are relevant to value operations, but it would mean outlining would benefit all types, and it would let us avoid bundling in unnecessary information from the enclosing generic environment. A minor side-effect of this is that we no longer bind names to opened element type values. The names were things like \tau_1_0, which is not very useful, especially in LLVM IR where \tau is printed with two UTF-8 escapes.
a pack expansion.
…ions. This probably isn't the right way to do it --- maybe there isn't a right way to do it besides fixing the passes to handle this properly. But it gets the optimizer off our back for the moment.
|
@swift-ci Please test |
rjmccall
force-pushed
the
more-variadic-fixes
branch
from
e7cfe18
to
81c4e07
Compare
rjmccall
requested review from
slavapestov and
nate-chandler
and removed request for
hyp,
egorzhdan and
zoecarver
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets a test case suggested by Holly working. Builds on #64273.