New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SILGen: Allow +0 parameter forwarding in protocol witness and re-abstraction thunks #6485
Merged
slavapestov
merged 7 commits into
apple:master
from
slavapestov:plus-zero-for-michael-maybe-he-will-like-it
Nov 20, 2017
Merged
SILGen: Allow +0 parameter forwarding in protocol witness and re-abstraction thunks #6485
slavapestov
merged 7 commits into
apple:master
from
slavapestov:plus-zero-for-michael-maybe-he-will-like-it
Nov 20, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks! |
@swift-ci Please smoke test |
Please don't merge this. I am going to be working in this area soon. |
slavapestov
force-pushed
the
plus-zero-for-michael-maybe-he-will-like-it
branch
from
November 9, 2017 07:13
2eb1a9c
to
61e3f2e
Compare
slavapestov
force-pushed
the
plus-zero-for-michael-maybe-he-will-like-it
branch
2 times, most recently
from
November 20, 2017 02:22
5c05022
to
930d859
Compare
…abstracting tuples
slavapestov
force-pushed
the
plus-zero-for-michael-maybe-he-will-like-it
branch
from
November 20, 2017 04:59
930d859
to
d0423e7
Compare
slavapestov
force-pushed
the
plus-zero-for-michael-maybe-he-will-like-it
branch
from
November 20, 2017 05:37
d0423e7
to
e688da3
Compare
@swift-ci Please test |
@swift-ci Please test source compatibility |
@swift-ci Please benchmark |
1 similar comment
@swift-ci Please benchmark |
Build failed |
@swift-ci Please benchmark |
Build comment file:Optimized (O)Regression (18)
Improvement (43)
No Changes (273)
Unoptimized (Onone)Regression (2)
Improvement (96)
No Changes (236)
Hardware Overview
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When emitting a thunk, such as a protocol witness thunk, we pass the arguments of the thunk to the callee, possibly performing some transformations on those parameters, such as converting indirect parameters to direct parameters.
If the parameters were owned or +1, we would pass them along to the callee. If the parameter was +0, we would perform an elaborate dance where we would copy or retain the value, pass the copy to the callee, and then destroy or release the copy. This is unnecessary, and a +0 value can be forwarded just like a +1 value.