[stdlib] Implement Never conformance to Codable #64899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natecook1000
added
the
swift evolution proposal needed
natecook1000
changed the title
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test |
natecook1000
added
swift evolution pending discussion
From looking at other failure points, it looks like dataCorrupted is more used for structural issues, e.g. malformed JSON.
|
@swift-ci Please test |
natecook1000
added
swift evolution approved
natecook1000
added a commit
to natecook1000/swift
that referenced
this pull request
May 9, 2023
Proposed as SE-0396: Conform Never to Codable; approved on 5/5/2023.
nickolas-pohilets
pushed a commit
to nickolas-pohilets/swift
that referenced
this pull request
May 12, 2023
Proposed as SE-0396: Conform Never to Codable; approved on 5/5/2023.
natecook1000
added a commit
that referenced
this pull request
May 16, 2023
apporc
added a commit
to greymass/swift-eosio
that referenced
this pull request
Mar 19, 2024
this is a try to fix the chaos `Never` introduced inside this library, there is a high chance change below is the final source. apple/swift#64899 At least unit test passes after it removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supplies conditional conformance for
Neverto theCodableprotocol.Pitch thread: https://forums.swift.org/t/pitch-conform-never-to-codable/64056/21