New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backtracing][Linux] Add Linux crash handler to the runtime. #66334
Conversation
This also adds a function to demangle a symbol, and a way for the backtracing code to report warning messages to the same place as the main runtime. I'd like to rename the _swift_isThunkFunction() SPI also, but we can't do that until we've made the changes to the _Backtracing library, so we'll do that there instead. rdar://110261430
@swift-ci Please smoke test |
This was added to a later PR, but not to this one, though we need it here. rdar://110261430
@swift-ci Please smoke test |
This should have been disabled until apple#66338. rdar://110261430
@swift-ci Please smoke test |
If you're wondering where the tests are, I left them until the last PR (#66338) so everything was enabled and they'd actually work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few little comments, but LGTM.
Mike and Max made various helpful suggestions, so I've added and updated various comments and amended the code to cope with partial reads and writes. rdar://110261430
Moved the comment for `_swift_backtrace_demangle` into the header file instead of it being in the implementation. rdar://110261430
@swift-ci Please smoke test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This also adds a function to demangle a symbol, and a way for the backtracing code to report warning messages to the same place as the main runtime.
I'd like to rename the
_swift_isThunkFunction()
SPI also, but we can't do that until we've made the changes to the_Backtracing
library, so we'll do that there instead.rdar://110261430