New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Parser] Fix-it for declaration attributes being applied to parameter types (SR-215) #673
Conversation
/*escaping=*/false)); | ||
} else { | ||
// Fix for SR215 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually don't leave references to bug numbers in C++ sources.
Please also add tests. |
@gribozavr Thanks for the comments. I've added a test and removed the reference to the bug number. |
@SquaredTiki Thank you! Sorry for the delayed response, but would you mind rebasing and resolving conflicts with master? |
d32734d
to
6b7eb00
Compare
@gribozavr No worries! I've rebased and resolved conflicts. |
// Check if attribute is invalid type attribute | ||
// and actually a declaration attribute | ||
if (TypeAttributes::getAttrKindFromString(nextToken.getText()) == TAK_Count | ||
&& DeclAttribute::getAttrKindFromString(nextToken.getText()) != TAK_Count) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it say DAK_Count
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite right, let me fix that now.
[Parser] Fix-it for declaration attributes being applied to parameter types (SR-215)
@SquaredTiki Sorry, this PR caused test failures, so I reverted it.
|
@SquaredTiki Please run |
[pull] swiftwasm from master
Un-XFail Kingfisher
As described in SR-215, previously the fix-it was suggesting that declaration attributes applied to parameter types be moved to before the function
func
declaration itself.This pull request fixes this so that it is instead moved to before the parameter name.