Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.9][Macros] Add missing macro validation. #67387

Merged
merged 3 commits into from
Jul 19, 2023

Conversation

hborla
Copy link
Member

@hborla hborla commented Jul 19, 2023

  • Explanation: Fixes the last remaining holes (that I know of!) in macro validation, adding diagnostics for:
    • Extension macros generating names not documented in the @attached(extension) attribute.
    • Extension macros generating conformances not documented in the @attached(extension) attribute.
    • Macro attributes attached to declarations that the macro does not apply to, such as a member macro attached to an import declaration.
  • Scope: Only affects attached macros.
  • Risk: Low due to narrow scope.
  • Testing: Added new test cases.
  • Reviewer: @DougGregor
  • Issue: rdar://111685434&112163965
  • Main branch PR: [Macros] Add missing macro validation. #67106, [Macros] Diagnose undocumented conformances in extension macro expansions. #67383

@hborla hborla requested a review from a team as a code owner July 19, 2023 03:57
@hborla
Copy link
Member Author

hborla commented Jul 19, 2023

@swift-ci please test

@hborla hborla merged commit 8b3938b into apple:release/5.9 Jul 19, 2023
5 checks passed
@hborla hborla deleted the 5.9-macro-validation branch July 19, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants