Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.9] Update macro help in driver and diagnostics #67886

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

bnbarham
Copy link
Contributor

Cherry-pick #67834 and #67885 into release/5.9

  • Explanation: -load-plugin-executable compiler option is the primary supported way of using macro plugin. SwiftPM uses this when developers use .macro() target. The driver help text should clarify the format and the semantics of the arguments. The diagnostic shouldn't mention -plugin-path or -load-plugin-library.
  • Scope: Driver help message and diagnostic
  • Risk: Extremely low, just some string changes
  • Testing: Passes current test suite
  • Issues: rdar://113646544

Clarify the format of the option and semantics.

rdar://113646544
@bnbarham bnbarham requested a review from a team as a code owner August 11, 2023 03:28
@bnbarham bnbarham added swift 5.9 🍒 release cherry pick Flag: Release branch cherry picks and removed 🍒 release cherry pick Flag: Release branch cherry picks labels Aug 11, 2023
@bnbarham
Copy link
Contributor Author

@swift-ci please test

This is a very large diagnostic, where the second half is mostly aimed
at macro authors rather than clients. Cut it down to the base
diagnostic.

Resolves rdar://113646544.
@bnbarham
Copy link
Contributor Author

@swift-ci please test

@bnbarham bnbarham merged commit 901d3f8 into apple:release/5.9 Aug 14, 2023
5 checks passed
@bnbarham bnbarham deleted the 5.9-update-macro-help branch August 14, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants