Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build-script-impl: For cmake configuration use distcc #6834

Closed
wants to merge 1 commit into from
Closed

build-script-impl: For cmake configuration use distcc #6834

wants to merge 1 commit into from

Conversation

erg
Copy link
Contributor

@erg erg commented Jan 16, 2017

No description provided.

@erg
Copy link
Contributor Author

erg commented Jan 16, 2017

@swift-ci Please smoke test

@erg erg force-pushed the cmake-distcc-configuration branch from 95a7443 to e9d8994 Compare January 16, 2017 04:46
@erg
Copy link
Contributor Author

erg commented Jan 16, 2017

@swift-ci Please smoke test

@erg erg force-pushed the cmake-distcc-configuration branch from e9d8994 to 66a13e5 Compare January 16, 2017 05:04
build-script-impl: For cmake configuration, if the compiler is
66a13e5 
``-DCMAKE_C_COMPILER:PATH=/opt/distcc-r796/bin/distcc``, then we need to
call cmake with pump but restrict it to localhost, or else cmake can run
the compiler remotely on the configuration step.

https://github.com/apple/swift/pull/6763/commits

rdar://problem/29942258
@erg
Copy link
Contributor Author

erg commented Jan 16, 2017

@swift-ci Please smoke test

@erg erg requested a review from dabrahams January 16, 2017 05:20
dabrahams
dabrahams reviewed Jan 16, 2017
View reviewed changes
Copy link
Contributor

@dabrahams dabrahams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't make sense. I don't understand why we would ever want to use distcc for a pure configuration step.

@erg
Copy link
Contributor Author

erg commented Jan 16, 2017

If the assumption is that the cmake configure step distributes to other machines if the C compiler path is something like -DCMAKE_C_COMPILER:PATH=/opt/distcc-r796/bin/distcc, then configuring through distcc but restricting the machines to localhost should stop clang from distributing.

If that's not what's happening, then I still don't know what to do.

@dabrahams
Copy link
Contributor

I guess I don't know enough to make a judgement here. If you test it and everything works as it should with and without distcc, I can't argue.

@shahmishal
Copy link
Member

@erg what is the status of this PR?

@jrose-apple
Copy link
Contributor

@erg isn't working on Swift anymore, so we can probably close it. (He can always reopen if he picks it up again.)

@shahmishal
Copy link
Member

@jrose-apple Sounds good!

@shahmishal shahmishal closed this Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabrahams dabrahams dabrahams left review comments

@HuskyAlvarez HuskyAlvarez HuskyAlvarez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erg @dabrahams @shahmishal @jrose-apple @HuskyAlvarez