Don't trust the external cache when looking for field descriptors #68557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
mikeash
approved these changes
Sep 15, 2023
| for (size_t i = 0; i < ReflectionInfos.size(); ++i) { | ||
| if (ExternalTypeRefCache && ExternalTypeRefCache->isReflectionInfoCached(i)) | ||
| continue; | ||
| if (auto FD = findFieldDescriptorAtIndex(i, *MangledName)) | ||
| return *FD; | ||
| } | ||
|
|
||
| // If we still haven't found the field descriptor, go over every reflection | ||
| // info, even the ones the external cache supposedly processed. |
There was a problem hiding this comment.
Can you clarify whether this is intended as a workaround for a specific issue, or whether the contract for ExternalTypeRefCache is that it should only serve as a positive cache and not cache negative lookups?
There was a problem hiding this comment.
The initial motivation was as a workaround to a specific bug, but I'm thinking that this should be the behavior even we solve the other bug. What do you think?
There was a problem hiding this comment.
Either behavior is fine, I just wanted to make sure we explicitly document the contract in the code.
When looking for field descriptors for a typeref, we should iterate over every image info available, even those that the cache claimed to have processed, as a last ditch effort. rdar://114567246
augusto2112
force-pushed
the
dont-trust-external-cache
branch
from
92cb439
to
a6be181
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking for field descriptors for a typeref, we should iterate over every image info available, even those that the cache claimed to have processed, as a last ditch effort.
rdar://114567246