[WIP] Task.sleep(.max) awakes immediately #69118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
commented
Oct 11, 2023
| fprintf(stderr, "[%s:%d](%s) monotonic time mask, | mask: %llu\n", __FILE_NAME__, __LINE__, __FUNCTION__, DISPATCH_UP_OR_MONOTONIC_TIME_MASK); | ||
| fprintf(stderr, "[%s:%d](%s) monotonic time mask, value | mask: %llu\n", __FILE_NAME__, __LINE__, __FUNCTION__, value | DISPATCH_UP_OR_MONOTONIC_TIME_MASK); | ||
| // return value | DISPATCH_UP_OR_MONOTONIC_TIME_MASK; | ||
| return value; // FIXME: sure this "works" but that's not the right fix I suppose... |
There was a problem hiding this comment.
So this "works" but seems quite wrong... I was poking around in the withDeadline impl here but tbh not entirely sure where the issue resides... might be best for you @phausler to have a look at the swift_task_enqueueGlobalWithDeadlineImpl and make it pass the added tests now
phausler
reviewed
Oct 11, 2023
| let t = Task.detached { | ||
| print("Run infinite sleep") | ||
| try? await Task.sleep(for: .nanoseconds(UInt64.max)) | ||
| print("Infinite sleep done (cancelled: \(Task.isCancelled)) @ \(#function)") |
There was a problem hiding this comment.
I think we should adjust it on the Swift side (at the point of concrete clocks) to clamp the value there; because testing it like this gets a duration of 709551615000000000 seconds, 18446744073 attoseconds
There was a problem hiding this comment.
Hm so just cap it at Int64.max on the swift side perhaps...
There was a problem hiding this comment.
yea, that seems reasonable to me (or cap and loop)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task.sleep(nanoseconds: .max)returns immediately #59174For now reproducing the issue and need to figure out why dispatch behaves like this and what we want to do about it.