-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rebranch] Merge main -> rebranch #69293
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d from a derived class synthesized method The use of a synthesized C++ method allows us to avoid making a copy of self when invoking the base method from Swift
If tuple element is anchored on an assignment, we need to look at the source of the assignment to find tuple expression the element belongs to.
…ement failure Only simplified locator points to the right underlying expression. Resolves: rdar://116122902
…ibleOrNone to avoid detaching doccomments from their declarations
…void detaching doccomments from their decls
…-elimination and dead-store-elimination. Instead of having a budget for each optimized load or store, provide a budget for the whole function. Fixes a build time problem. rdar://116877696
Always print the real module name for references in private swiftinterfaces, ignoring export-as declarations. Keep using the export-as name for the public swiftinterface only. The flag `ModuleInterfaceExportAs` used to enable this behavior and we're removing it to make it the default. rdar://115922907
…d or subscript from a derived class synthesized method The use of a synthesized C++ method allows us to avoid making a copy of self when accessing the base field or subscript from Swift
…t a retainable FRT value This matches the semantics of accessing the same field from the base class
Passing the flags `-enable-experimental-feature ModuleInterfaceExportAs` has no effect anymore, test that it's not reported as an error.
Optimizer: better handling of the complexity budget in redundant-load-elimination and dead-store-elimination
Introduce the upcoming feature `FullTypedThrows`. When enabled, infer the error type of a `throw` statement based on its original type, instead of always being `any Error`. This is technically a source-breaking change, hence the upcoming feature flag.
Older compilers don't have the copy-elision of newer C++ compilers, resulting in an error message when returning a non-copyable type. Move llvm::Error instead of copying it.
…ed-accessor [cxx-interop] Use a synthesized C++ method when invoking a base metho…
…overlays aren't being built Allow for the overlays to not be built in Darwin by respecting SWIFT_BUILD_SDK_OVERLAY.
Add `swift-syntax-lib` component to the distribution set.
For testing compiler support until we have the ~Escapable syntax.
This will allow NonEscapable types to be returned from a function.
If SILGen emitted a marker, that ought to be indication enough that move only checking is necessary.
…by-default ModuleInterface: Always ignore export-as for printing references in private swiftinterfaces
…option [embedded] Don't gate embedded stdlib build behind SWIFT_BUILD_STDLIB
bnbarham
requested review from
hyp,
egorzhdan,
ktoso,
kavon,
AnthonyLatsis,
tshortli,
compnerd and
eeckstein
as code owners
October 19, 2023 23:20
bnbarham
requested review from
shahmishal and
etcwilde
and removed request for
xedin,
compnerd,
slavapestov,
ktoso,
rintaro,
kavon,
hyp,
DougGregor,
CodaFi,
egorzhdan,
ahoppen,
artemcm,
hborla,
zoecarver,
eeckstein,
tshortli and
AnthonyLatsis
October 19, 2023 23:20
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conflicts:
lib/AST/TypeCheckRequests.cpp
renamedisMoveOnly
which requiresa static_cast on rebranch because
Optional
is now astd::optional
Also fixed
IsEscapableRequest::getCachedResult
which needs a similarstatic_cast
.