Add ld-path-driver-option to features.json
#69586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `-ld-path` option was introduced on `main` in apple/swift-driver#1442 and 5.10 in apple/swift-driver#1442. SwiftPM needs to detect this flag to pass options to the driver correctly, and it's suitable to do this via `feature.json` instead of checking for the compiler version via other means.
MaxDesiatov
added
the
driver options
|
@swift-ci test |
bnbarham
approved these changes
Nov 2, 2023
MaxDesiatov
added a commit
that referenced
this pull request
Nov 4, 2023
Dependency of apple/swift-package-manager#7021. Cherry-pick of #69586. The `-ld-path` option was introduced on `main` in apple/swift-driver#1442 and 5.10 in apple/swift-driver#1442. SwiftPM needs to detect this flag to pass options to the driver correctly, and it's suitable to do this via `feature.json` instead of checking for the compiler version via other means. Partially resolves rdar://117049947.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency of apple/swift-package-manager#7021.
The
-ld-pathoption was introduced onmainin apple/swift-driver#1442 andrelease/5.10in apple/swift-driver#1442. SwiftPM needs to detect this flag to pass options to the driver correctly, and it's suitable to do this viafeature.jsoninstead of checking for the compiler version via other means.Partially resolves rdar://117049947.