Sema: Associated type inference skips witnesses that might trigger a request cycle [5.10] #69952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…request cycle This implements a structural walk over the TypeRepr to catch situations where we attempt to infer `A` from `func f(_: A)`, which references the concrete `A` that will be synthesized in the conforming type. Fixes: - rdar://34956654 / apple#48680 - rdar://38913692 / apple#49066 - rdar://56672411 - apple#50010 - rdar://81587765 / apple#57355 - rdar://117442510
|
@swift-ci Please test |
hborla
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Associated type inference would get in trouble if an associated type witness was inferred, but also referenced from inside a type by an unqualified lookup. In this case some declaration checking orders could cause cycles.
Scope of the issue: Frequently duped issue.
Origination: Forever.
Risk: Medium.
Reviewed by: @tshortli
Radars/Issues: