Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename instances of “OS X” to “macOS” #70364

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tonyarnold
Copy link
Contributor

This is a reworking of #12674, as rebasing became a bit of a dead end.

Here is @graydon's original PR description:

It's been pointed out that swiftc still uses 'OSX' or 'OS X' in a lot of places it ought to be saying 'macOS' now. This change switches many, but not all, of those cases. In particular it fixes those cases where the compiler gives feedback about availability guards (the original report was about these) as well as switching internal symbols and docs.

Notably: this change does not eliminate support for 'OSX' in availability checks (it's still a synonym) nor does it change all of the tests that use 'OSX' in those checks; I figured there was no point since the synonym is likely to be supported in perpetuity and it's good to test that fact too. Moreover this change does not alter the terminology in any of the configury or build system; it's my hope that by avoiding that, I can avoid unintentional breakage, though I suspect I'll still be breaking something.

Opinions welcome on how else to stage this.

rdar://35127522

Resolves #54205.

@Rish-it
Copy link

Rish-it commented Dec 11, 2023

i don't have a permission to commit
and upstream is already exist

@tonyarnold
Copy link
Contributor Author

tonyarnold commented Dec 11, 2023

@Rish-it you'll need to fork the repository to your own account, and push a new branch there. You won't be able to push to Graydon's original fork and branch, nor to the main Swift repository.

See the GettingStarted.md documentation for more details: https://github.com/apple/swift/blob/main/docs/HowToGuides/GettingStarted.md#setting-up-your-fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SR-11795] Replace OSX with macOS pretty much everywhere
2 participants