[Macros] Reproduce issue with peer+extension macro extension's methods not being checked as witnesses #71717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etect extension macros Both `PotentialMacroExpansionsInContextRequest` and `populateLookupTableEntryFromMacroExpansions` expected extension macros only on extensions synthesized by macros. That is not the same in practice and such attached macros could appear on types as well.
xedin
force-pushed
the
wip-reproduce-macros-witness-issue
branch
from
28136f6
to
a6d53aa
Compare
|
@swift-ci please smoke test |
ktoso
commented
Feb 19, 2024
| nominal = container.getBaseNominal(); | ||
|
|
||
| if (nominal) | ||
| forEachPotentialAttachedMacro(nominal, MacroRole::Extension, nameTracker); | ||
| } |
|
resolves rdar://123012943 |
|
@swift-ci please smoke test Linux |
ktoso
changed the title
|
@swift-ci please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This narrows down and reproduces rdar://123012943
This is blocking the
@_DistributedProtocolmacro from working entirely since the methods introduced by the extension macro are not seen as witnesses.It happens when a macro is both peer and extension;
extensionnames: arbitrarybecause we don't know statically what method names we'll introduce -- it depends on the protocol we're attached tonames: prefixed('$')... that seems to break things and the methods in the extension don't get "noticed" as witnesses'peer' macros are not allowed to introduce arbitrary names at global scopeSo this is somewhat blocked -- this looks like a bug in handling the names in the extension macro role, and not looking for the witnesses.
If a macro is made to be just extension the macro's introduced methods do properly witness the requirement.