Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IRGen] Don't call objc_retainAutoreleasedReturnValue() without interop. #72011

Merged
merged 2 commits into from Mar 2, 2024
Merged

[IRGen] Don't call objc_retainAutoreleasedReturnValue() without interop. #72011

merged 2 commits into from Mar 2, 2024
+57 −4

Commits on Mar 1, 2024

  1. [IRGen] Don't call objc_retainAutoreleasedReturnValue() without interop. 

    When ObjC interop is not enabled, we shouldn't be emitting calls to
`objc_retainAutoreleasedReturnValue()` as that function might not exist.

Call `swift_retain()` instead, to balance the `swift_release()` of the
returned value.

Fixes apple#47846, apple#45359.

rdar://23335318
    @al45tair
    al45tair committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    d0c35cf View commit details
    Browse the repository at this point in the history

  2. [IRGen][Test] Update tests for non-Linux platform support. 

    Tweak the tests slightly for WASM, Windows and Darwin.

rdar://23335318
    @al45tair
    al45tair committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    0d7c575 View commit details
    Browse the repository at this point in the history