Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Repair CF bridging call test for non x64 targets #72042

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Mar 2, 2024

The test was failing on aarch64 targets because the notail is specified only for x86_64 targets.

Command Output (stderr):
--
/home/build-user/swift/test/IRGen/cf_objc_retainAutoreleasedReturnValue.swift:20:11: error: CHECK: expected string not found in input
// CHECK: %1 = notail call ptr @llvm.objc.retainAutoreleasedReturnValue(ptr %0)
          ^
<stdin>:19:40: note: scanning from here
 %0 = call ptr @returnsACFBridgedType()
                                       ^
<stdin>:21:2: note: possible intended match here
 %1 = call ptr @llvm.objc.retainAutoreleasedReturnValue(ptr %0)
 ^

Input file: <stdin>
Check file: /home/build-user/swift/test/IRGen/cf_objc_retainAutoreleasedReturnValue.swift

#72011

@kateinoigakukun
Copy link
Member Author

@swift-ci smoke test

@kateinoigakukun
Copy link
Member Author

Hmm, do we have a way to trigger aarch64 CI jobs?

@MaxDesiatov
Copy link
Member

@swift-ci test apple silicon

The test was failing on aarch64 targets because the `notail` is
specified only for x86_64 targets.
@kateinoigakukun kateinoigakukun force-pushed the yt/repair-linux-aarch64-autorelease branch from 2e99ffc to e617ecf Compare March 2, 2024 17:34
@kateinoigakukun
Copy link
Member Author

@swift-ci test apple silicon

@kateinoigakukun
Copy link
Member Author

@swift-ci smoke test

@kateinoigakukun kateinoigakukun merged commit abec584 into apple:main Mar 3, 2024
4 checks passed
@kateinoigakukun kateinoigakukun deleted the yt/repair-linux-aarch64-autorelease branch March 3, 2024 05:14
@al45tair
Copy link
Contributor

al45tair commented Mar 4, 2024

Thanks for fixing this :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants