#56350 - Give Identifier a hasUnderscoredNaming() helper #72048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jamezzzb
requested review from
zoecarver,
hyp,
egorzhdan,
hborla,
slavapestov,
xedin,
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
ahoppen
reviewed
Mar 4, 2024
include/swift/Sema/CSFix.h
Outdated
Comment on lines
1338
to
1339
| auto name = PropertyWrapper->getName(); | ||
| return !name.hasUnderscoredNaming(); |
There was a problem hiding this comment.
We could shorten this even further now
Suggested change
| auto name = PropertyWrapper->getName(); | |
| return !name.hasUnderscoredNaming(); | |
| return !PropertyWrapper->getName().hasUnderscoredNaming(); |
There was a problem hiding this comment.
@ahoppen Thanks! I like this better but hadn't thought of it. With suggestions is there a preference whether I do it locally so I can squash or is it okay to apply it here? In terms of keeping the commit history clean.
There was a problem hiding this comment.
Squashing would be appreciated.
There was a problem hiding this comment.
Alright done. Thank you.
…aces currently using str().startsWith, change it to use the new helper.
ahoppen
approved these changes
Mar 5, 2024
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#56350
I gave Identifier a hasUnderscoredNaming() helper. Which is just:
I put it right under
hasDollarPrefixfiguring that made the most sense. I also replaced parts of the code usingstr().startsWith("_")to use the new helper. I think the helper makes intention more clear and it is definitely more convenient (especially with code completion).I then reran swift/test:
There are 6 failures but these same tests always fail for me. I haven't looked too much into the failures (one is a module not being found, another is I am missing some python stuff) but I don't think they are related to the changes.