[embedded] Add a flag to specify whether the module is leaf or library #72688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubamracek
requested review from
tshortli,
hborla,
slavapestov and
xedin
as code owners
phausler
reviewed
Mar 28, 2024
| @@ -585,6 +585,8 @@ ERROR(objc_with_embedded,none, | |||
| "Objective-C interoperability cannot be enabled with embedded Swift.", ()) | |||
| ERROR(no_allocations_without_embedded,none, | |||
| "-no-allocations is only applicable with embedded Swift.", ()) | |||
| ERROR(optimize_embedded_module_without_embedded,none, | |||
| "-optimize-embedded-module-as is only applicable with embedded Swift.", ()) | |||
There was a problem hiding this comment.
should this be restricted to just embedded? couldn't we perhaps also use this leaf vs lib optimization in non-embedded cases too?
There was a problem hiding this comment.
yes, it would give benefits in regular swift, too. Assuming build systems, like swifpm, support this option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two new flags, restricted to only be available under Embedded Swift:
-optimize-embedded-module-as=leaf-- this will allow more optimizations, specifically dead-code elimination and possibly removal of things that would normally be an ABI break (e.g. vtable entries) but if the module cannot have any clients, then it's not an ABI break-optimize-embedded-module-as=libraryThis is just adding the flag, further work with enable the actual optimizations.