[Concurrency] Perform Sendable checking on parameter and result types for async function conversions that change actor isolation. #72691
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such conversions are unsafe because they allow sneaking non-Sendable types across isolation boundaries:
This change isn't ready yet (just putting the PR up so I don't forget about it!) because it doesn't handle function conversions in the other direction - nonisolated functions converted to global actor isolated functions. However, the constraint system currently injects function conversions from nonisolated functions to global actor isolated functions for all calls to global actor isolated functions due to the way
adjustFunctionTypeForConcurrency
is called. I believe we need to split that function up into two steps - one that adds global actor isolation, and a separate one that strips annotations for@preconcurrenty
. The first function type should be used as the original type and the stripped function type should be used as the adjusted type, eliminating the function conversion except in the cases where it's needed for@preconcurrency
. Then, this code in the actor isolation checker can be applied to function conversations that add global actor isolation.