[6.0] Implement proper visibility rules for imported extensions #72974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an extension isn't imported either directly or via a transitive (`@_exported`) import, its members should not be visible to name lookup. Implement this behavior behind the experimental flag ExtensionImportVisibility.
This eliminates some diagnostics that incorrectly refer to a missin `@_spi` import as an outright missing import, which is incorrect. The one test case changed here really is a case of a missing import that happens to be SPI.
To prevent performance regressions from calling `findImport()` more frequently, request-ify the computation. NFC. Prerequisite of rdar://16154294
This didn't expose any missing imports in the sources of any of the standard library modules, but that's not entirely surprising. Still, we should have the feature enabled to test it and prevent regressions from creeping in before the behavior becomes the default. Exclude `ExtensionImportVisibility` from module interfaces.
|
@swift-ci please test |
nkcsgexi
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@_exported) import, its members should not be visible to name lookup. Implement this behavior behind the experimental flagExtensionImportVisibility. This feature will be pitched on Swift Evolution as a potential source breaking change to make in a future language mode.ExtensionImportVisibilityexperimental feature #72871, Tests: Add more tests for ExtensionImportVisibility #72969