Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look through @Sendable conversions when considering C function pointer conversions. #73436

Merged

Conversation

jckarter
Copy link
Member

@jckarter jckarter commented May 4, 2024

Adding (or removing) @Sendable doesn't add context, so it shouldn't prevent conversion to a C function pointer. Fix for rdar://127521718.

…ter conversions.

Adding (or removing) `@Sendable` doesn't add context, so it shouldn't prevent
conversion to a C function pointer. Fix for rdar://127521718.
@jckarter jckarter requested review from hborla and xedin as code owners May 4, 2024 00:51
@jckarter
Copy link
Member Author

jckarter commented May 4, 2024

@swift-ci Please test

@jckarter jckarter merged commit b107a5e into apple:main May 6, 2024
5 checks passed
Copy link
Member

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jckarter I think a better fix here would be to not introduce this conversion AST node during CSApply for C function pointers (that happens in adjustTypeForDeclReference).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants