[SILGen] Fix a crash when a closure is converted to a block returning a value indirectly #73520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a value indirectly Fix the type of the function argument added to the entry basic block. rdar://127745392
|
@swift-ci please test |
|
@swift-ci please test macOS |
egorzhdan
approved these changes
May 9, 2024
|
There's a bug (assertion failure) in IRGen, which I found just now. |
|
@swift-ci please test |
|
@swift-ci please test |
ahatanaka
commented
May 14, 2024
| @@ -392,7 +392,8 @@ static void buildFuncToBlockInvokeBody(SILGenFunction &SGF, | |||
| if (blockTy->getNumResults() != 0) { | |||
| auto result = blockTy->getSingleResult(); | |||
| if (result.getConvention() == ResultConvention::Indirect) { | |||
| indirectResult = entry->createFunctionArgument(blockResultTy); | |||
There was a problem hiding this comment.
It doesn't seem to make any difference, but I wonder whether blockConv.getSingleSILResultType(SGF.getTypeExpansionContext())) should be passed instead of blockResultTy.getAddressType() to createFunctionArgument.
There was a problem hiding this comment.
I think what you've got is right.
rjmccall
approved these changes
May 23, 2024
| @@ -392,7 +392,8 @@ static void buildFuncToBlockInvokeBody(SILGenFunction &SGF, | |||
| if (blockTy->getNumResults() != 0) { | |||
| auto result = blockTy->getSingleResult(); | |||
| if (result.getConvention() == ResultConvention::Indirect) { | |||
| indirectResult = entry->createFunctionArgument(blockResultTy); | |||
There was a problem hiding this comment.
I think what you've got is right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the type of the function argument added to the entry basic block.
rdar://127745392