Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initialization of imported ObjC block types. #73577

Merged
merged 1 commit into from May 13, 2024

Conversation

atrick
Copy link
Member

@atrick atrick commented May 11, 2024

This fixes a SIL ownership verification error when importing structs like:

typedef bool (^boolBlock)(void);

struct objc_bool_block {
__unsafe_unretained boolBlock block;
};

Fixes rdar://126142109 (Found an operand with a value that is not compatible with the operand's operand ownership kind map)

This fixes a SIL ownership verification error when importing structs like:

typedef bool (^boolBlock)(void);

struct objc_bool_block {
  __unsafe_unretained boolBlock block;
};

Fixes rdar://126142109 (Found an operand with a value that is not compatible
with the operand's operand ownership kind map)
@atrick atrick requested a review from egorzhdan May 11, 2024 00:46
@atrick
Copy link
Member Author

atrick commented May 11, 2024

@swift-ci test

Copy link
Collaborator

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super familiar with this logic, but this looks reasonable, thank you!

@atrick atrick merged commit 4272552 into apple:main May 13, 2024
5 checks passed
@atrick atrick deleted the fix-init-objc-block branch May 13, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants