Opt remarks: emit remarks when we fail to serialize a function in CMO. #73657
Conversation
zoecarver
requested review from
tshortli,
hborla,
slavapestov and
xedin
as code owners
| @@ -274,6 +274,9 @@ def Raccess_note : Separate<["-"], "Raccess-note">, | |||
| def Raccess_note_EQ : Joined<["-"], "Raccess-note=">, | |||
| Alias<Raccess_note>; | |||
|
|
|||
| def Rserialization_failed : Flag<["-"], "serialization-failed">, | |||
There was a problem hiding this comment.
Missing an R here, and the name could probably be improved anyway.
There was a problem hiding this comment.
Maybe:
cross-module-optimization-serialization-failed
Remark if we failed to serialize a function for the purpose of cross module optimization
There was a problem hiding this comment.
Sounds good to me.
|
Nitpick: 2-space indentation. |
| return; | ||
|
|
||
| auto &ctx = i->getModule().getASTContext(); | ||
| auto joined = remark.str() + other.str(); |
There was a problem hiding this comment.
Could you use llvm::Twine for string concatenation.
There was a problem hiding this comment.
I'm going to need to turn it into a string anyway to then turn it into a StringRef
There was a problem hiding this comment.
And then I think we need to globally allocate it in the AST context so that it's not deallocated by the time the diagnostic fires
| return false; | ||
|
|
||
| auto &ctx = f->getModule().getASTContext(); | ||
| auto joined = remark.str() + other.str(); |
There was a problem hiding this comment.
Same here: could you use llvm::Twine for string concatenation?
|
Thanks for the review comments! |
|
@swift-ci please smoke test |
|
@swift-ci smoke test |
|
@swift-ci smoke test |
No description provided.