Use get_python_lib to look for lldb python lib dir. #7685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@rintaro @modocache Hi, you both helped to review the original change that introduced this functionality + test. Could you review the above PR? Background: Attempts to make Swift build Fedora is currently hitting issues where _lldb.so end up in different dir (lib64 vs lib) and aren't correctly located by the test. Full discussion on SR-100. |
|
The change itself LGTM. |
|
@swift-ci please smoke test |
rintaro
reviewed
Feb 23, 2017
| @@ -34,6 +34,7 @@ config.android_ndk_path = "@SWIFT_ANDROID_NDK_PATH@" | |||
| config.android_ndk_gcc_version = "@SWIFT_ANDROID_NDK_GCC_VERSION@" | |||
|
|
|||
| config.coverage_mode = "@SWIFT_ANALYZE_CODE_COVERAGE@" | |||
| config.lldb_build_root = "@LLDB_BUILD_DIR@" | |||
There was a problem hiding this comment.
Ah, we need this line in validation-test/lit.site.cfg.in too. Otherwise,
File "/home/rintaro/Documents/swift-oss/swift/test/lit.cfg", line 1073, in <module>
if config.lldb_build_root != "":
AttributeError: TestingConfig instance has no attribute 'lldb_build_root'
There was a problem hiding this comment.
Yep, fixed that already, thanks.
gmilos
force-pushed
the
sr-100-lit-python-search-path
branch
from
f4cc383
to
e07eb41
Compare
|
@swift-ci please smoke test |
rintaro
approved these changes
Feb 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fedora builds are currently failing due to https://github.com/apple/swift/blob/202ee90b5d62c55582cc451c0ea2854a0f6a4cca/test/Runtime/linux-fatal-backtrace.swift failing to find the lldb bindings in lldb-python-path.
Prerequisite to resolve SR-100.