[3.1] [Constraint solver] Dont assume orphans are along in the inactive list. #7741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The inactive list may contain other disjunctions associated with bound type variables. For now, make sure we recover the orphan directly to fix the crash in SR-4056 / rdar://problem/30686926. Later, we can treat these as orphans, too. (cherry picked from commit 99a1396)
|
@swift-ci please test |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: The inactive list may contain other disjunctions associated with bound
type variables, which will cause the constraint solver to crash.
Scope: The crash showed up with a fairly simple expression involving ?. and ??, so it could potentially hit a significant amount of code. The code causing the crash is fairly new (merged on Monday).
SR Issue: https://bugs.swift.org/browse/SR-4056
rdar://problem/30686926
Risk: Fairly low; it's a small "obvious" change to the orphan-constraint-handling code.
Testing: Compiler regression testing, plus the example from the fixed SR.