[build-script] When building with asan, mangle asan into the build subdirectory name. #8169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please python lint |
|
@swift-ci smoke test and merge |
…bdirectory name. Today, when you enable ASAN, build-script just reconfigures your normal build directory to use ASAN. This forces you to recompile LLVM and Swift with ASAN enabled and then (once you have finished using ASAN) to recompile LLVm/Swift without ASAN. By using a different build-directory, one still has to (potentially) recompile LLVM/Swift, but one's original directory has not become invalidated. Thus when you switch back to a normal build, one does not have to recompile LLVM and (potentially) Swift!
gottesmm
force-pushed
the
asan_build_subdir
branch
from
b5ecd0c
to
824ffa6
Compare
|
@swift-ci smoke test and merge |
1 similar comment
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[build-script] When building with asan, mangle asan into the build subdirectory name.
Today, when you enable ASAN, build-script just reconfigures your normal build
directory to use ASAN. This forces you to recompile LLVM and Swift with ASAN
enabled and then (once you have finished using ASAN) to recompile LLVm/Swift
without ASAN.
By using a different build-directory, one still has to (potentially) recompile
LLVM/Swift, but one's original directory has not become invalidated. Thus when
you switch back to a normal build, one does not have to recompile LLVM and
(potentially) Swift!