[silgen] Add helper methods to compute ArgumentSource::getSubst{RValue,}Type() as SILTypes. #8297
Conversation
…e,}Type() as SILTypes. rdar://31145255
|
@jckarter How does this look? I just want to make sure I am doing this right, |
|
@swift-ci Please smoke test |
| SILType ArgumentSource::getSILSubstRValueType(SILGenFunction &SGF) const & { | ||
| CanSILFunctionType funcType = SGF.F.getLoweredFunctionType(); | ||
| CanType substType = getSubstType(); | ||
| AbstractionPattern origType(funcType->getGenericSignature(), substType); |
There was a problem hiding this comment.
Is the argument value always emitted at the most substituted abstraction level?
I don't think you need the abstraction pattern at all then. substType should not contain any interface type parameters, so just calling getLoweredType(substType) should work?
There was a problem hiding this comment.
I am not sure. So I was trying to make this the most general correct manner of performing the operation, so if I was incorrect it would just be a no-op. That is why I wanted to ask you guys. ; ).
There was a problem hiding this comment.
You could add an assert that when the argument source is eventually evaluated down to a single managed value, the type of that matches the expected SIL type.
There was a problem hiding this comment.
I would rather just be careful for now.
[silgen] Add helper methods to compute ArgumentSource::getSubst{RValue,}Type() as SILTypes.
rdar://31145255