Separate out ObjC code in def_basic Serialization tests. #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests pass on OS X and Linux. |
| @@ -9,8 +9,6 @@ | |||
| // RUN: %target-build-swift -Xfrontend %clang-importer-sdk -emit-module -Xfrontend -disable-diagnostic-passes -force-single-frontend-invocation -Xfrontend -sil-serialize-all -o %t/def_basic.swiftmodule %S/Inputs/def_basic.sil | |||
| // RUN: %target-build-swift -Xfrontend %clang-importer-sdk -emit-silgen -Xfrontend -sil-link-all -I %t %s | FileCheck -check-prefix=CHECK_DECL %S/Inputs/def_basic.sil | |||
There was a problem hiding this comment.
Could you remove -Xfrontend %clang-importer-sdk and -I %S/../Inputs/clang-importer-sdk/swift-modules everywhere in this file? They are not needed anymore.
This change moves functionality that requires ObjC interop into a new file and removes the XFAIL on Linux. Partially resolves SR-216.
|
@gribozavr Thanks! The PR has been updated to remove the obsolete import and SDK. |
gribozavr
added a commit
that referenced
this pull request
Jan 6, 2016
Separate out ObjC code in def_basic Serialization tests.
|
@ezephir Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves functionality that requires ObjC interop into a new file and
removes the XFAIL on Linux. Partially resolves SR-216.
Tested on Ubuntu 14.04 and Mac OS X 10.10.