Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[closure-specializer] Support specialization of closures with @inout address parameters #9987

Merged
merged 2 commits into from May 30, 2017
Merged

[closure-specializer] Support specialization of closures with @inout address parameters #9987

merged 2 commits into from May 30, 2017

Conversation

swiftix
Copy link
Contributor

@swiftix swiftix commented May 30, 2017

No description provided.

@swiftix
[sil-opened-archetypes-tracker] Not all of type dependent operands de…
501943a 
…finitions are SILInstructions

E.g. dynamic_self definitions may be represented by SILArguments.
@swiftix
[closure-specializer] Support specialization of closures with address…
597dc8e 
… parameters
@swiftix
Copy link
Contributor Author

swiftix commented May 30, 2017

@swift-ci please smoke test

@swiftix
Copy link
Contributor Author

swiftix commented May 30, 2017

@jckarter Joe, do you mind taking a look? This PR enables support for closure arguments passed as @inout address types.

@swiftix swiftix requested a review from jckarter May 30, 2017 20:41
jckarter
jckarter approved these changes May 30, 2017
View reviewed changes
Copy link
Member

@jckarter jckarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@swiftix swiftix merged commit 1043628 into apple:master May 30, 2017
@swiftix swiftix mentioned this pull request May 30, 2017
Closed
@swiftix swiftix mannequin mentioned this pull request May 30, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jckarter jckarter jckarter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@swiftix @jckarter