Fixing Install Script Typo & adding Conda Install Support #63
Conversation
UpdateAs of 02/02/2021, Apple has updated this copy of TensorFlow. I have created a Conda Environment File to make it easier to install TensorFlow to MiniForge (not Anaconda -- Anaconda is not ARM compatible). Instructions on how to do this are tentatively posted on: #153 Original PostTo install Tensorflow in a Conda-supported Python, DO NOT USE ANACONDA. Anaconda is not ARM supported. Use Miniforge which is noted in step 1.
|
|
Hey is there anything I can do to help out with this? Would be happy to help if there's something you'd like me to clean up or improve. Thanks! |
|
Hello @mwidjaja1, thank you for the fantastic work here! We're figuring out how to include this in some way in our next release. As you can imagine, there are non-engineering matters to resolve around taking contributions, but we're figuring it out. |
|
Gotcha! I'd be willing to sign anything away if needed if that's legally required 🙂. I don't know if it helps either but I am an Apple Public Beta Tester so I have those agreements 'signed off on' technically speaking already. |
|
Hi @mwidjaja1, Thank you for the fantastic work! I'm talking about this message. |
|
@shixnya hi, I suffer from not having an 'activate' in the envs/tf/bin, which cause me failed to the installation, do you know what a 'activate' if for or how can I get it right? thanks. |
|
Hi @heathentw You are right. The issue that I raised is that 'activate' script will not be generated in Conda environment because it's an option of the 'conda' command. You can run this instead of activate script. |
|
@mwidjaja1 I tried installing using your steps shown above, but unfortunately I get an error when running the installation script: Im sure it's a dumb mistake of mine, but yea... |
|
@redmlr You should not be renaming any directories or moving any files around, which your terminal output makes it sound like you did. Both your script and a directory named |
| 3. Download the archive file from the [releases](https://github.com/apple/tensorflow_macos/releases) | ||
| 4. Run `scripts/install_venv.sh --prompt` and at the prompt, provide the path to your environment's directory. For example: `~/miniforge3/envs/tensorflow` if your env name is `tensorflow` and you installed Miniforge ot your home directory. | ||
|
|
||
| #### Notes/Users/Matthew/miniforge3/envs/tensorflow |
There was a problem hiding this comment.
| #### Notes/Users/Matthew/miniforge3/envs/tensorflow | |
| #### Notes |
| 1. Download a Python 3.8 for Apple Silicon ARM from https://github.com/conda-forge/miniforge/#download and install it. | ||
| 2. [Optional] Create a Python 3.8 Conda Environment for TensorFlow | ||
| 3. Download the archive file from the [releases](https://github.com/apple/tensorflow_macos/releases) | ||
| 4. Run `scripts/install_venv.sh --prompt` and at the prompt, provide the path to your environment's directory. For example: `~/miniforge3/envs/tensorflow` if your env name is `tensorflow` and you installed Miniforge ot your home directory. |
There was a problem hiding this comment.
| 4. Run `scripts/install_venv.sh --prompt` and at the prompt, provide the path to your environment's directory. For example: `~/miniforge3/envs/tensorflow` if your env name is `tensorflow` and you installed Miniforge ot your home directory. | |
| 4. Run `scripts/install_venv.sh --prompt` and at the prompt, provide the path to your environment's directory. For example: `~/miniforge3/envs/tensorflow` if your env name is `tensorflow` and you installed Miniforge in your home directory. |
I think the |
Yes, I downloaded the wrong one.. Even though I now downloaded the release package, the installation script outputs that my miniforge environment is not an virtual environment.. |
|
@redmlr You have to modify the script with my proposed changes in place, without moving the script or anything. I don't think you fully modified it. |
@mwidjaja1 do you mean these? |
Thank you for your help @mwidjaja1, I appreciate it! |
|
@redmlr I don't use PyCharm anymore but I can tell you there IS a way to connect a Conda/Miniforge env to PyCharm and I was able to do it last year. That should be a Googling task outside the scope of this particular MR though -- I can't help you too much more in that area. Glad you got it working at least outside of PyCharm for now! |
hoytak
force-pushed
the
master
branch
2 times, most recently
from
5a13fe6
to
0e31f05
Compare
Update
As of 02/02/2021, Apple has updated this copy of TensorFlow. I have created a Conda Environment File to make it easier to install TensorFlow to MiniForge (not Anaconda -- Anaconda is not ARM compatible). Instructions on how to do this are tentatively posted on: #153
Original PR
Hello there,
I'd like to propose this PR to address two issues:
bin/activatefor Python and being more clever with when we need to activate it (i.e. only when we're using a virtual env), we can make the installation script work for Conda/Miniforge installs. I also added documentation to Readme.md about how one can install Tensorflow on Conda if they'd like.