Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Functionality of prediction_id in predict of Activity Classifier #1706

Closed
shreyajain17 opened this issue Apr 8, 2019 · 5 comments · Fixed by #2659
Closed

Functionality of prediction_id in predict of Activity Classifier #1706

shreyajain17 opened this issue Apr 8, 2019 · 5 comments · Fixed by #2659

Comments

@shreyajain17
Copy link
Collaborator

The functionality of prediction_id column given as output of predict when making prediction per window is not clear in documentation. The output given at the moment is the following.

|      253      |   1    | [  4.63483302e-04   9.9950... |
|      254      |   1    | [  7.90477672e-04   9.9914... |
|      255      |   1    | [  4.41032015e-02   9.5374... |
|      256      |   2    | [  7.02369167e-03   2.4149... |
|      257      |   2    | [  5.60363929e-04   3.1854... |
|      258      |   2    | [  1.27506602e-04   6.1436... |
|      259      |   2    | [  6.75232295e-05   2.6096... |
@nickjong nickjong added the p3 label May 16, 2019
@nickjong nickjong added the docs label Jul 31, 2019
@nickjong nickjong added this to the 5.7 milestone Jul 31, 2019
@shreyajain17
Copy link
Collaborator Author

@nickjong I don't think it should be solved with docs though. I mean the column prediction_id has no use if it just like the index/row number of the SFrame.

@fareeha fareeha assigned fareeha and unassigned fareeha Aug 6, 2019
@nickjong nickjong removed this from the 5.7 milestone Aug 6, 2019
@nickjong nickjong added p2 and removed docs p3 labels Aug 6, 2019
@nickjong
Copy link
Collaborator

nickjong commented Aug 6, 2019

From offline discussion, sounds like this is an occasion where the code is wrong, and needs to be fixed to match the intent captured in the user guide

@srikris
Copy link
Contributor

srikris commented Nov 12, 2019

@nickjong Is this fixed in #2431. If so, can this be closed?

@syoutsey
Copy link
Collaborator

If the prediction_id has been removed from the output, then we'll also want to update the docs to match this.

@nickjong
Copy link
Collaborator

No, our end goal was not to remove prediction ID but to implement it correctly (starting over from 1 within each session). In #2431 we punted on doing it correctly and just removed it temporarily.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants