This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
Implement "prediction_id" column for "per_window" prediction for AC #2659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds this column for `predict` and updates the semantics for `classify`. Unlike 5.8, this column now gives the index of the prediction within the session (instead of the index overall, which is just the row number in the result table) Also fixes some places where the result SFrame should use the user's column name for the session ID, not the string "session_id"
shreyajain17
approved these changes
Nov 18, 2019
| @@ -516,10 +516,10 @@ simple_data_iterator::simple_data_iterator(const parameters ¶ms) | |||
| next_row_(range_iterator_.begin()), | |||
| end_of_rows_(range_iterator_.end()), | |||
| sample_in_row_(0), | |||
| num_chunks_in_row_(0), | |||
There was a problem hiding this comment.
This is a good idea!
jakesabathia2
suggested changes
Nov 18, 2019
jakesabathia2
approved these changes
Nov 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds this column for
predictand updates the semantics forclassify. Unlike 5.8, this column now gives the index of the prediction within the session (instead of the index overall, which is just the row number in the result table)Also fixes some places where the result SFrame should use the user's column name for the session ID, not the string "session_id"
Fixes #1706