Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

turicreate.load_audio does not fail on invalid path #2686

Closed
hoytak opened this issue Nov 19, 2019 · 2 comments · Fixed by #2751
Closed

turicreate.load_audio does not fail on invalid path #2686

hoytak opened this issue Nov 19, 2019 · 2 comments · Fixed by #2751
Assignees
@dhivyaaxim
Labels
bug sounds

Comments

@hoytak
Copy link
Collaborator

hoytak commented Nov 19, 2019

Turicreate load_audio does not fail if a path does not exist:

data = tc.load_audio("Path does not exist")

simply produces an empty sframe.
@dhivyaaxim
Copy link
Contributor

@hoytak Please assign this ticket to me as I would like to try fixing it and contribute .Thanks in advance!

@shreyajain17
Copy link
Collaborator

shreyajain17 commented Nov 23, 2019 •
edited
Loading

It also seems to not work on correct relative path.

@dhivyaaxim dhivyaaxim mentioned this issue Nov 25, 2019
Merged
hoytak pushed a commit that referenced this issue Dec 3, 2019
@dhivyaaxim
turicreate.load_audio does not fail on invalid path (#2751)
50c9330 
This PR resolves #2686: turicreate.load_audio does not fail on invalid path
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dhivyaaxim dhivyaaxim

Labels
bug sounds
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

turicreate.load_audio does not fail on invalid path dhivyaaxim/turicreate
4 participants
@hoytak @TobyRoseman @dhivyaaxim @shreyajain17