Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Prevent installing on systems that are not x86_64 #27

Closed
srikris opened this issue Dec 9, 2017 · 8 comments
Closed

Prevent installing on systems that are not x86_64 #27

srikris opened this issue Dec 9, 2017 · 8 comments
Assignees
Labels

Comments

@srikris
Copy link
Contributor

srikris commented Dec 9, 2017

We don't have any checks for x86_64. We should have our wheels restrict to only the platforms that we support. Ideally with names like this: numpy-1.13.3-cp35-cp35m-manylinux1_x86_64.whl

@gustavla
Copy link
Collaborator

gustavla commented Dec 9, 2017

The pypi files for 4.0 permit more than we support. Even if we fix this for say 4.0.1, users on unsupported platforms would still get 4.0 if they simply did pip install turicreate. Of course, we never want to change 4.0, but we might be able to consider a name change of the files for 4.0 that simply will prevent users on unsupported platforms to get broken installs.

@srikris srikris added the bug label Dec 9, 2017
@znation
Copy link
Contributor

znation commented Dec 13, 2017

The work here is twofold:

  • Build a wheel, instead of an egg, for Linux.
  • Remove the 4.0 egg so that users on unsupported platforms don't get that one on pip install.

Open question: should we backport this fix to 4.0 and publish a 4.0 wheel for Linux? Not sure if this is even possible on PyPI.

@znation znation self-assigned this Dec 13, 2017
@gustavla
Copy link
Collaborator

I think you can remove old versions, but you can't re-upload them (maybe twine can circumvent, but I'm not sure). It looks we will probably need to pull version 4.0 from pypi at some point in the future, or issues where users try to install on an unsupported platform will never be fixed:

@TobyRoseman
Copy link
Collaborator

@gustavla - twine does not allow you to circumvent that.

@gustavla
Copy link
Collaborator

@TobyRoseman Good to know (I read some vague reference at pypa/packaging-problems#74 to suggest otherwise, but reading it again I think you are right). We'll probably have to pull it at some point in time then.

@znation
Copy link
Contributor

znation commented Dec 21, 2017

@gustavla @TobyRoseman Another option would be to publish a newer version of a pure Python egg named turicreate, along with our future releases, but instead of containing a non-working version of Turi Create, it could error out on setup with a user-facing message re: platform/version support?

@gustavla
Copy link
Collaborator

gustavla commented Jan 3, 2018

@znation That would work, yes. I think that's probably our best solution given the circumstances, unless we are willing to remove 4.0 from PyPI soon after the next release comes out.

znation added a commit that referenced this issue Mar 13, 2018
* Add a setup.py for a source distribution

We will use this one for erroring out on unsupported platforms, by
uploading it as an egg (source distribution). If a user's pip install
falls back to the egg (no compatible wheel) they will see this error
message.

* Fixes #27

* Removed unused import
@znation
Copy link
Contributor

znation commented Mar 13, 2018

4.2 egg with error message on install has been published to https://pypi.python.org/pypi/turicreate/4.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants