-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Prevent installing on systems that are not x86_64 #27
Comments
The pypi files for 4.0 permit more than we support. Even if we fix this for say 4.0.1, users on unsupported platforms would still get 4.0 if they simply did |
The work here is twofold:
Open question: should we backport this fix to 4.0 and publish a 4.0 wheel for Linux? Not sure if this is even possible on PyPI. |
I think you can remove old versions, but you can't re-upload them (maybe twine can circumvent, but I'm not sure). It looks we will probably need to pull version 4.0 from pypi at some point in the future, or issues where users try to install on an unsupported platform will never be fixed:
|
@gustavla - twine does not allow you to circumvent that. |
@TobyRoseman Good to know (I read some vague reference at pypa/packaging-problems#74 to suggest otherwise, but reading it again I think you are right). We'll probably have to pull it at some point in time then. |
@gustavla @TobyRoseman Another option would be to publish a newer version of a pure Python egg named |
@znation That would work, yes. I think that's probably our best solution given the circumstances, unless we are willing to remove 4.0 from PyPI soon after the next release comes out. |
* Add a setup.py for a source distribution We will use this one for erroring out on unsupported platforms, by uploading it as an egg (source distribution). If a user's pip install falls back to the egg (no compatible wheel) they will see this error message. * Fixes #27 * Removed unused import
4.2 egg with error message on install has been published to https://pypi.python.org/pypi/turicreate/4.2 |
We don't have any checks for x86_64. We should have our wheels restrict to only the platforms that we support. Ideally with names like this: numpy-1.13.3-cp35-cp35m-manylinux1_x86_64.whl
The text was updated successfully, but these errors were encountered: