This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
Handle null values in numeric histogram #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srikris
approved these changes
Jan 23, 2019
shantanuchhabra
approved these changes
Jan 24, 2019
Previously, all null values were ignored. With this change, if there are any missing values (true None, not NaN), they get counted separately in a categorical bin that is separated from the X axis. This change does not yet account for NaN/inf values. Those are still being ignored.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, all null values were ignored. With this change, if there are
any missing values (true None, not NaN), they get counted separately in
a categorical bin that is separated from the X axis.
This change does not yet account for NaN/inf values. Those are still
being ignored.
Depends on #1324