Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Fill missing values in categorical heatmap #1331

Merged
merged 1 commit into from Jan 28, 2019
Merged

Fill missing values in categorical heatmap #1331

merged 1 commit into from Jan 28, 2019

Conversation

znation
Copy link
Contributor

@znation znation commented Jan 17, 2019

This addresses two issues with categorical heatmap:

  • Previously, null keys were omitted from both axes. Now, the counts are
    included, in a separate category called "(null)".
  • Previously, keys with no counts were treated as missing (empty
    transparent rectangles in the plot). Now, they are filled with zeroes
    for plot purposes.

Depends on #1324

Copy link
Collaborator

@shantanuchhabra shantanuchhabra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This addresses two issues with categorical heatmap:

* Previously, null keys were omitted from both axes. Now, the counts are
  included, in a separate category called "(null)".
* Previously, keys with no counts were treated as missing (empty
  transparent rectangles in the plot). Now, they are filled with zeroes
  for plot purposes.
@znation znation merged commit 3bba361 into apple:master Jan 28, 2019
@znation znation deleted the viz_categorical_heatmap_fill_missing branch January 28, 2019 06:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants