This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
Add official support for MXNet 0.12 and unofficial support for MXNet 1.X #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- attr was renamed to attrs - add official support for 0.12 - 1.X theroetically works, but 1.0.0 is broken for the object detector, so let's hold off official support until 1.0.1.
|
I just pushed a commit that:
With these changes, this PR fully rolls out official 0.12.1 support. |
znation
approved these changes
Jan 5, 2018
This was referenced Jan 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, we have support for pretty much all versions of MXNet from 0.11.
I updated the support in
setup.pytomxnet >= 0.11, mxnet < 1.0.0. This PR makes 1.0.0 theoretically work, but that version causes a segfault in the object detector. This segfault seems to be fixed in every subsequent nightly release, so hopefully it will not be an issue in 1.0.1. When that version is released, we can extend official support for 1.X and remove or update themxnet < 1.0.0.