This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
Fix JSON export of array dtype #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the formatting of the `flex_vec` (array) dtype in CSV export from SFrame. Still quite a few bugs lurking in the JSON export -- I also tested inf/nan handling and it's broken. Leaving that commented out in the test for now. I suspect other things are broken too (namely datetime or Image types - not sure how to reasonably JSON export those). We might want to consider extensions._json for JSON export.
hoytak
reviewed
Jan 15, 2018
|
@hoytak I'm not sure what you mean by previous difference. If you think changing the |
|
Yes. The csv localized fix is better. The flexible_type has never promised JSON compatibility and it is not about to sign up for that. |
ylow
approved these changes
Jan 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the formatting of the
flex_vec(array) dtype in CSV exportfrom SFrame.
Still quite a few bugs lurking in the JSON export -- I also tested
inf/nan handling and it's broken. Leaving that commented out in the test
for now. I suspect other things are broken too (namely datetime or Image
types - not sure how to reasonably JSON export those).
We might want to consider extensions._json for JSON export.