This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
Document clarification for different representation for bounding box between Turi Create and Vision #2320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shantanuchhabra
approved these changes
Sep 17, 2019
nickjong
suggested changes
Sep 20, 2019
| @@ -99,7 +99,8 @@ def _find_only_column_of_type(sframe, target_type, type_name, col_name): | |||
| raise ToolkitError('No "{col_name}" column specified and more than one {type_name} column in "dataset". Can not infer correct {col_name} column.'.format(col_name=col_name, type_name=type_name)) | |||
| image_column_name = name | |||
| if image_column_name is None: | |||
| raise ToolkitError('No %s column in "dataset".' % type_name) | |||
| raise ToolkitError('No "{col_name}" column specified and no column with expected type "{type_name}" is found.'.format(col_name=col_name, type_name=type_name) | |||
There was a problem hiding this comment.
This looks like a fix for an unrelated bug (unrelated to "Documentation clarification for OD")
In general, you should avoid mixing together branches for different bugs. Each PR should just merge the changes/commits for the issue it's fixing!
| @@ -37,6 +37,8 @@ For more details on the integration with Core ML and a sample app to get | |||
| you started, please look at the the article on | |||
| [Recognizing Objects in Live Capture](https://developer.apple.com/documentation/vision/recognizing_objects_in_live_capture). | |||
|
|
|||
| **Note:** The bounding box object `VNRecognizedObjectObservation.boundingBox` has a different definition from the one used for Turi Create. First, the location of the bounding box is defined by the upper-left corner of the rectangle instead of the center. Secondly, the location, width, and height for the bounding box are all normalized between [0,1] by the dimensions of the images. | |||
There was a problem hiding this comment.
I believe Vision uses the lower left corner as the origin of the coordinates, and the lower-left corner of the bounding box to define the position. Is this not what you're observing?
There was a problem hiding this comment.
Just changed the documentation.
jakesabathia2
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1016
close #1984