This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
Fix slicing issue for NDArray inside SArray (Python 3) #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes test_sarray.py::SArrayTest::test_ndarray_shape to fail. That test also fails for another reason that will be addressed separately.
This was referenced Mar 21, 2018
hoytak
approved these changes
Mar 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes
test_sarray.py::SArrayTest::test_ndarray_shapeto fail.That test also fails for another reason that will be addressed separately.
Fixes #355.